Print error code #2800
Open
Print error code #2800
+113
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NopeDl
force-pushed
the
print-error-code
branch
5 times, most recently
from
771b668 to
44cf9e1
Compare
|
cicheck |
Signed-off-by: NopeDl <h2012497638@outlook.com>
NopeDl
force-pushed
the
print-error-code
branch
from
44cf9e1 to
91ad4ad
Compare
|
cicheck |
2 similar comments
|
cicheck |
|
cicheck |
add topology support and remove storage status Signed-off-by: NopeDl <h2012497638@outlook.com>
NopeDl
force-pushed
the
print-error-code
branch
from
9abc9fc to
3f71912
Compare
|
cicheck |
wu-hanqing
reviewed
Nov 2, 2023
src/mds/common/mds_define.h
Outdated
| @@ -47,6 +47,27 @@ const int kCsClientReturnFail = -5; | |||
| // error code: chunkserver offline | |||
| const int kCsClientCSOffline = -6; | |||
|
|
|||
| const char* PrintMdsDescByErrorCode(int code) { | |||
There was a problem hiding this comment.
Suggested change
| const char* PrintMdsDescByErrorCode(int code) { | |
| inline const char* MdsErrCodeToName(int code) { |
src/mds/common/mds_define.h
Outdated
| @@ -104,6 +125,59 @@ const int kTopoErrCodePoolsetNotFound = -20; | |||
| const int kTopoErrCodeCannotDeleteDefaultPoolset = -21; | |||
| const int kTopoErrCodeConflictBlockSizeAndChunkSize = -22; | |||
|
|
|||
| const char* PrintTopoErrCodeDescription(int code) { | |||
There was a problem hiding this comment.
Suggested change
| const char* PrintTopoErrCodeDescription(int code) { | |
| inline const char* TopoErrCodeToName(int code) { |
Signed-off-by: NopeDl <h2012497638@outlook.com>
|
@NopeDl continue? |
Ziy1-Tan
reviewed
Dec 11, 2023
| @@ -47,6 +47,27 @@ const int kCsClientReturnFail = -5; | |||
| // error code: chunkserver offline | |||
| const int kCsClientCSOffline = -6; | |||
|
|
|||
| inline char* MdsErrCodeToName(int code) { | |||
There was a problem hiding this comment.
Suggested change
| inline char* MdsErrCodeToName(int code) { | |
| inline const char* MdsErrCodeToName(int code) { |
|
cicheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2185
What is changed and how it works?
What's Changed: print error code with more meaningful name
How it Works: use the function to convert error code to string
Side effects(Breaking backward compatibility? Performance regression?):
Check List